report: fix wording when screenEmulation disabled #14587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
adamraine
reviewed
Dec 5, 2022
report/renderer/util.js
Outdated
| let deviceEmulation = Util.i18n.strings.runtimeMobileEmulation; | ||
| if (settings.screenEmulation.disabled) { | ||
| deviceEmulation = Util.i18n.strings.runtimeNoEmulation; | ||
| } else if (settings.formFactor === 'desktop') { |
There was a problem hiding this comment.
I still think we should use settings.screenEmulation.mobile here because the strings refer to the emulated device and not scoring methodology.
That should only matter when the formFactor and screenEmulation.mobile disagree for some reason so this is probably fine.
adamraine
approved these changes
Dec 5, 2022
brendankenny
reviewed
Dec 5, 2022
| const get = settings => Util.getEmulationDescriptions(settings).deviceEmulation; | ||
| /* eslint-disable max-len */ | ||
| assert.equal(get({formFactor: 'mobile', screenEmulation: {disabled: false, mobile: true}}), 'Emulated Moto G4'); | ||
| assert.equal(get({formFactor: 'mobile', screenEmulation: {disabled: true, mobile: true}}), 'No emulation'); |
There was a problem hiding this comment.
this does bring it back to @connorjclark's point that there's no indication this was a mobile report now
There was a problem hiding this comment.
Adding a separate indicator for that would be fine, I just don't think it makes sense here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14560